fix registration error handling

felixheck · Jul 14, 2017 · f70e134 · f70e134
1 parent 5665d3a
commit f70e134
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -22,8 +22,7 @@ function plugin (server, options, next) {
 
   server.register(logger(options), (err) => {
     if (err) {
-      console.error(err)
-      process.exit(1)
+      return next(err)
     }
 
     if (options.override) {

diff --git a/test/init.spec.js b/test/init.spec.js
@@ -5,6 +5,16 @@ test('throw error if plugin gets registered twice', (t) => {
   t.throws(() => helpers.registerPlugin(helpers.getServer()), Error)
 })
 
+test('throw error if nested plugin throws error', (t) => {
+  t.throws(() => helpers.registerPlugin(helpers.getServer({
+    hapiPino: {
+      tags: {
+        foo: 'bar'
+      }
+    }
+  })), Error)
+})
+
 test('throw error if own options are invalid – colored', (t) => {
   t.throws(() => helpers.getServer({
     colored: null