Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for three versions > 132.1 #197

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Conversation

enijar
Copy link
Contributor

@enijar enijar commented Apr 29, 2022

During npm install with the current peerDependancy of three@^132.1 users will receive an error if they have a version greater than 132.1. This update fixes this install error, allowing users to use newer versions of three.

@swingingtom
Copy link
Collaborator

swingingtom commented Apr 29, 2022

Hey @enijar, thanks for this PR.
I didn't test three-mesh-ui with latest versions of three and I don't have time right now. Which version do you use in your current setup, and can you tell if it work as expected? If so, I will merge and release asap.

Thanks !

@enijar
Copy link
Contributor Author

enijar commented Apr 29, 2022

@swingingtom ^0.139.2 and it works on my local when I test it in my integration project

@swingingtom swingingtom merged commit f25327e into felixmariotto:master Apr 29, 2022
@swingingtom
Copy link
Collaborator

v6.4.3 released. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants