fix: get counts of all statuses, to be aligned with Bull

felixmosh · Mar 28, 2024 · 5a71520 · 5a71520
1 parent 95f7cfa
commit 5a71520
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/packages/api/src/handlers/queues.ts b/packages/api/src/handlers/queues.ts
@@ -69,7 +69,7 @@ async function getAppQueues(
         !isActiveQueue || query.status === 'latest' ? jobStatuses : [query.status as JobStatus];
       const currentPage = +query.page || 1;
 
-      const counts = await queue.getJobCounts(...jobStatuses);
+      const counts = await queue.getJobCounts();
       const isPaused = await queue.isPaused();
 
       const pagination = getPagination(status, counts, currentPage, jobsPerPage);

diff --git a/packages/api/src/queueAdapters/base.ts b/packages/api/src/queueAdapters/base.ts
@@ -47,7 +47,7 @@ export abstract class BaseAdapter {
 
   public abstract getJob(id: string): Promise<QueueJob | undefined | null>;
 
-  public abstract getJobCounts(...jobStatuses: JobStatus[]): Promise<JobCounts>;
+  public abstract getJobCounts(): Promise<JobCounts>;
 
   public abstract getJobs(
     jobStatuses: JobStatus[],

diff --git a/packages/api/src/queueAdapters/bull.ts b/packages/api/src/queueAdapters/bull.ts
@@ -34,8 +34,7 @@ export class BullAdapter extends BaseAdapter {
     return this.queue.getJobs(jobStatuses, start, end).then((jobs) => jobs.map(this.alignJobData));
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  public getJobCounts(..._jobStatuses: JobStatus<'bull'>[]): Promise<JobCounts> {
+  public getJobCounts(): Promise<JobCounts> {
     return this.queue.getJobCounts() as unknown as Promise<JobCounts>;
   }
 

diff --git a/packages/api/src/queueAdapters/bullMQ.ts b/packages/api/src/queueAdapters/bullMQ.ts
@@ -35,8 +35,8 @@ export class BullMQAdapter extends BaseAdapter {
     return this.queue.getJobs(jobStatuses, start, end);
   }
 
-  public getJobCounts(...jobStatuses: JobStatus[]): Promise<JobCounts> {
-    return this.queue.getJobCounts(...jobStatuses) as unknown as Promise<JobCounts>;
+  public getJobCounts(): Promise<JobCounts> {
+    return this.queue.getJobCounts() as unknown as Promise<JobCounts>;
   }
 
   public getJobLogs(id: string): Promise<string[]> {