Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Unit-Test Coverage for Insights Decorators #14

Open
felixnext opened this issue Jan 22, 2023 · 1 comment
Open

Increase Unit-Test Coverage for Insights Decorators #14

felixnext opened this issue Jan 22, 2023 · 1 comment
Labels
good first issue Good for newcomers technical-debt Overhaul of design decisions that will make the library more future proof and easier to work with

Comments

@felixnext
Copy link
Owner

felixnext commented Jan 22, 2023

Due to dependency conflicts the test-coverage for the insights decorator is extremely low.

The goal would be to fix that. This requires to mock a bunch of functionality in opencensus.

It also requires to define a clearer structure for multiple view defined in parallel.

This will likely require changes in the metrics as well.

Note: Some of the unit tests already exists, but are flaky. Hence they are marked as pytest.mark.skip

@felixnext
Copy link
Owner Author

Fixed some of these issues in #10, but still have no good mocking of Azure facing exporters (i.e. AzureLogExporter, AzureEventExporter, etc).
Would require a deeper locking into pytest-mock to make sure the base classes are mocked correctly.

@felixnext felixnext added good first issue Good for newcomers technical-debt Overhaul of design decisions that will make the library more future proof and easier to work with labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers technical-debt Overhaul of design decisions that will make the library more future proof and easier to work with
Projects
None yet
Development

No branches or pull requests

1 participant