Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Application Insights #10

Merged
merged 26 commits into from Jan 25, 2023
Merged

Conversation

felixnext
Copy link
Owner

Integrated new decorators for creating clean functions and passing through a logger object.
Also implemented OpenCensus Event and Logger items to be passed through to sync items to AppInsights.

Prepares for #9
Closes #6

@felixnext felixnext added the enhancement New feature or request label Jan 20, 2023
@felixnext felixnext self-assigned this Jan 20, 2023
@felixnext
Copy link
Owner Author

felixnext commented Jan 20, 2023

Still in draft. Open Tasks:

  • Update documentation on decorators
  • Properly implement Metrics
  • Fully test AppInsights sync in example function
  • Test the last_decorator flag
  • Provide sample implementations of metrics (call count & function runtime)
  • Split out function app examples
  • Integrate unit tests for all parts (including loglisthandler)
  • Ensure that decorator implementation is correct
  • Ensure in-order execution of unit-tests to avoid flakyness (i.e. results from global objects leaking into one another)
  • Add Unit Tests for remaining decorators
  • Implement proper mocking of Insights Functions (AzureLogExporter and AzureEventExporter) - might use a None Key to avoid passing them along? - pushed to Increase Unit-Test Coverage for Insights Decorators #14
  • Fix data retrieval from MetricsHandler and make it multi-thread / multi-metrics safe (unit-test flakyness)
  • Add Unit Tests for MetricDecorator
  • Look into porting to OpenTelemetrics Port Metrics SDK to OpenTelemetry #16

@felixnext
Copy link
Owner Author

Now also address #12 - Also added a bunch of unit tests

@felixnext felixnext linked an issue Jan 20, 2023 that may be closed by this pull request
@felixnext
Copy link
Owner Author

Also closes #9 - Note that this shapes up to be a breaking change - therefore bumped version to next major (1.0.0)

@felixnext felixnext linked an issue Jan 20, 2023 that may be closed by this pull request
@felixnext felixnext mentioned this pull request Jan 21, 2023
@felixnext felixnext linked an issue Jan 24, 2023 that may be closed by this pull request
@felixnext felixnext linked an issue Jan 25, 2023 that may be closed by this pull request
@felixnext felixnext merged commit 98fdcda into main Jan 25, 2023
@felixnext felixnext deleted the u/felixnext/23-01_app-insights branch January 25, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant