Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nana master doesn't build on Visual Studio 2017 #2

Closed
TBBle opened this issue Apr 17, 2017 · 1 comment
Closed

Nana master doesn't build on Visual Studio 2017 #2

TBBle opened this issue Apr 17, 2017 · 1 comment

Comments

@TBBle
Copy link

TBBle commented Apr 17, 2017

The develop branch of nana has cnjinhao/nana@e7181a7 which fixes the build for Visual Studio 2017, and needs to be cherry-picked.

Reference is https://connect.microsoft.com/VisualStudio/Feedback/Details/1403302 which indicates that the codecvt issue could not be fixed for VS2017 to maintain binary compatibility.
@FelixPetriconi
Copy link
Owner

Thanks for reporting it. I just fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TBBle @FelixPetriconi