fix: crash on missing RenderWidgetHostView (electron#38100)

chore: fix crash on missing RenderWidgetHostView
felixrieseberg · Apr 28, 2023 · 955af5a · 955af5a
1 parent 8b7a54d
commit 955af5a
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/shell/browser/ui/cocoa/electron_inspectable_web_contents_view.mm b/shell/browser/ui/cocoa/electron_inspectable_web_contents_view.mm
@@ -287,12 +287,14 @@ - (void)redispatchContextMenuEvent:(NSEvent*)event {
     // Temporarily pretend that the WebContents is fully non-draggable while we
     // re-send the mouse event. This allows the re-dispatched event to "land"
     // on the WebContents, instead of "falling through" back to the window.
-    api_contents->SetForceNonDraggable(true);
-    BaseView* contentsView = (BaseView*)contents->GetRenderWidgetHostView()
-                                 ->GetNativeView()
-                                 .GetNativeNSView();
-    [contentsView mouseEvent:event];
-    api_contents->SetForceNonDraggable(false);
+    auto* rwhv = contents->GetRenderWidgetHostView();
+    if (rwhv) {
+      api_contents->SetForceNonDraggable(true);
+      BaseView* contentsView =
+          (BaseView*)rwhv->GetNativeView().GetNativeNSView();
+      [contentsView mouseEvent:event];
+      api_contents->SetForceNonDraggable(false);
+    }
   }
 }