TOKEN_FILE location and whitespace
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/config.ts
Outdated
| @@ -10,7 +10,7 @@ export const config = { | |||
|
|
|||
| export const BASE_DIR = process.cwd(); | |||
| export const OUT_DIR = path.join(BASE_DIR, "slack-archive"); | |||
| export const TOKEN_FILE = path.join(OUT_DIR, ".token"); | |||
| export const TOKEN_FILE = path.join(BASE_DIR, ".token"); | |||
There was a problem hiding this comment.
This is a breaking change, so I'd rather not merge it in. The trim() above is a great idea though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
OUT_DIRis used as a docroot, it’s a good idea to put theTOKEN_FILEoutside this.Also, if the file contains a trailing newline, this causes the authorisation to fail.