Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.11.0 crash #43

Closed
cxfksword opened this issue Jun 17, 2018 · 21 comments
Closed

0.1.11.0 crash #43

cxfksword opened this issue Jun 17, 2018 · 21 comments

Comments

@cxfksword
Copy link
Contributor

when i start program, wait some seconds will crash, auto close then window. how can i fix it, has some crash log?

windows version: 1803

@felixse
Copy link
Owner

felixse commented Jun 17, 2018

Can you please open then Windows Event Viewer, go to Windows Logs -> Application, start the app and tell me the error details?

From your screenshot I can tell that both App and SystemTray are working, and a powershell has been created. Does your Powershell work when you start it in its native window?

@notlmn
Copy link

notlmn commented Jun 17, 2018

I haven't got time to open an issue but this is the very behavior for me since 0.1.9.0. Tried all versions and none of them even opened (can get to the settings view and change everything, but the application closes without any output).

The app launches (and closes), there is a tray icon, but there are no events in Event Viewer.

@felixse
Copy link
Owner

felixse commented Jun 17, 2018

Did you try with CMD as the default shell? Same behaviour?

@notlmn
Copy link

notlmn commented Jun 17, 2018

Tried with CMD, Powershell, and even WSL Bash. Same behavior as above (closes, no events).

@felixse
Copy link
Owner

felixse commented Jun 17, 2018

Ok, then I'm out of ideas for know.
Maybe you can find some time and try to debug it on your machine?

@Riebart
Copy link
Contributor

Riebart commented Jun 18, 2018

There's likely been some changes to the stuff stored in the roaming preferences/settings. If you aren't married to your FluentTerminal settings, try uninstalling the app, and installing the new one fresh? A less destructive, but also likely less decisive test, would be to just reset the app's data.

@notlmn
Copy link

notlmn commented Jun 18, 2018

Tried uninstalling and reinstalling several times, also tried removing any directory named FluentTerminal in %APPDATA%.

@notlmn
Copy link

notlmn commented Jun 18, 2018

@felixse I know this is out of scope of this issue, but can you provide dependencies and appx + cert as separate downloads, it's hard to download 80MB bundle repeatedly while on roaming? (I didn't want to open an issue to ask this.)

@felixse
Copy link
Owner

felixse commented Jun 18, 2018

Ok, so all I can offer you right now is to wait for the next release. I will add some logging to see whats going on.

I can provide a package without dependencies. This will only save 16mb, but better than nothing

@notlmn
Copy link

notlmn commented Jun 18, 2018

@felixse The problem got fixed after repeated installations (yes, repeated) of dependency packages and manually installing the cert file multiple times. 🎉🎈

A check for dependencies in the main launcher file?

And regarding package and dependencies, it looks like appxsym files are not required for installation (these files make up ~45MB of the total app). If these files are not required then the app would only be ~36MB.

@felixse
Copy link
Owner

felixse commented Jun 18, 2018

Nice to hear you got it working 😃
Nothing we actively do on our side, must be some weird appx installation bug.

appxsym seems to contain debug symbols, I think we can strip that as well for the 'light' download

@Riebart
Copy link
Contributor

Riebart commented Jun 19, 2018

I was able to reproduce it on a brand new install of Windows 10 1803 x64 in a VM, so there's something super weird going on here.

@felixse
Copy link
Owner

felixse commented Jun 19, 2018

And you got it running after trying it multiple times?

Tried it myself in a fresh 1803 VM a few days ago, but in my case it installed correctly at first try 😕

@Riebart
Copy link
Contributor

Riebart commented Jun 19, 2018

No, mine refused to run, but I did notice that the x64 2015 UWP runtime failed to install correctly, and installing it from the Dependencies folder didn't work (I had to install it form Powershell with Add-AppxPackage as it looked like the install window itself was causing the conflict, which was confusing).

@cxfksword
Copy link
Contributor Author

I run Add-AppDevPackage.ps1 by manual, and it works now.

@Riebart
Copy link
Contributor

Riebart commented Jun 21, 2018

Found it! I think.

This is a bit misleading, and I don't know what exact functionality is causing it, but if you just choose Sideload Apps in the Windows 10 developer settings, this is the behaviour you get. If you enable Developer Mode, without reinstalling anything, you get the correct behaviour. Ideally we wouldn't have to enable full-on developer mode to sideload the app, but I don't know what functionality we're using that triggers the issues.

Edit: Process: Confirmed on a fresh install of Windows 10 1803 (defaults to "Sideload Apps"). Installed the cert to Local Machine\Trust Root, double-clicked on the .appxbundle, opened the app, the UWP portion crashed, and the tray processes stayed alive. Closed the tray process, enabled Developer Mode, relaunched the app, and it opened correctly.

@felixse
Copy link
Owner

felixse commented Jun 21, 2018

Can you check whether the loop back exemption is set (you can use this to look it up: https://archive.codeplex.com/?p=loopback) when you are in the ‘crashing state’?

@Riebart
Copy link
Contributor

Riebart commented Jun 22, 2018

Got it:

I have confirmed that running

CheckNetIsolation LoopbackExempt -a -n="(
    (Get-AppxPackage | where { $_.Name -eq "53621FSApps.FluentTerminal" }).PackageFamilyName
)"

after installing the certificate and .appxbundle will fix the crash without requiring that you change the developer settings from "Sideload Apps". You'll need to run the command as administrator, but it will explicitly add the missing loopback permission for only the FluentTerminal app.

@Riebart
Copy link
Contributor

Riebart commented Jun 24, 2018

Sort of the last update I think on this:

I tested this by building it and explicitly revoking the LoopbackExempt status from the development package, and indeed what happens is that the websocket in the JavaScript side times out, and issues a .onclose(), which sense CloseTab to the terminal bridge.

So this is indeed caused by the same headache that's present in #34 . I'll make a PR that updates the README on how to install to note that if you're sideloading the app, you'll need to run the above PowerShell snippet

@felixse
Copy link
Owner

felixse commented Jun 24, 2018

Well, at least we found the issue and also a work around. I would consider this as resolved now, thanks to everyone who contributed here 😃

The fun continues in #34

@felixse felixse closed this as completed Jun 24, 2018
@corelon
Copy link

corelon commented Sep 4, 2018

Hi,
I am having the same issue, and although I followed the various steps above it will not start.

mjs pushed a commit to mjs/FluentTerminal that referenced this issue Apr 30, 2019
* Build msi installer for appx package

* Fix appvetor failure

* Run cmd commands in separate yml cmd sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants