Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended behavior #9

Closed
Nour-MK opened this issue Apr 2, 2024 · 5 comments
Closed

Unintended behavior #9

Nour-MK opened this issue Apr 2, 2024 · 5 comments
Labels

Comments

@Nour-MK
Copy link

Nour-MK commented Apr 2, 2024

Bug description

Screenshots seem to be taken only from the upper left corner of my screen.

Steps to reproduce

Nothing special. Exactly the steps given to us in the documentation. I tried it before changing any configurations and after some tweaking; both cases still only take a screenshot of the upper left corner.

Expected behavior

Take a screenshot of the whole monitor, as you usually would.
No I'm not currently using a dual monitor setup - so these complications are not on the table.

Device info

HP Envy x360

Additional context

I will be sure to reply to this issue if I figure out a way to fix it. There should be a way as I can take normal screenshots using windows' snip and ShareX. Also, I'm quite invested in the timelapse idea.

@Nour-MK Nour-MK added the bug label Apr 2, 2024
@felladrin
Copy link
Owner

That's interesting! Thanks for reporting!

There was a PR years ago that addressed a similar issue:

My guess is that Windows released some new feature related to the screen scaling that isn't supported by the 6-yo screenCapture.exe.

Before that PR, I used to recommend users to use Windows10_DPI_FIX.exe to fix issues related to screen scaling, but I'm not sure if this would work nowadays.

Unfortunately, I'm not using Windows anymore. Let's leave this issue open in the hope someone can come up with an idea to solve it 🙏

P.S. I once started rewriting windows-timelapse-toolkit using https://github.com/jangxx/node-win-desktop-duplication for capturing the screen. This should be a good starting point; I know it handles the screen scaling correctly due to the usage of Windows' Desktop Duplication API.

@felladrin
Copy link
Owner

Ah, I just noticed one thing: I haven't made a release after #6 was merged.

Could you confirm if you are using v1.1.0 or the main branch of a clone of this repository?

If you're using v1.1.0, that might be the reason of the issue, and you should try downloading master and running it instead. If it works, I'll update the Readme.

@Nour-MK
Copy link
Author

Nour-MK commented Apr 3, 2024

Yep, using v1.1.0; got it from the releases section.
chrome_RnHrr9nf0e

Onto downloading the master!

@Nour-MK
Copy link
Author

Nour-MK commented Apr 3, 2024

Downloaded the master, everything works as expected! Cheers (and congrats on this handy little tool I really appreciate it)! 🥳

@Nour-MK Nour-MK closed this as completed Apr 3, 2024
@felladrin
Copy link
Owner

Awesome, thank you for confirming!
I'll update the readme and get a new release out right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants