-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
1454b68
to
1e658b0
Compare
@felschr, in my fork, current the build succeeds but the job fails at the step where it tries to push the tag: https://travis-ci.org/am11/AspNetCore.Identity.DocumentDB/builds/207810945#L554. (however, this can be done va AppVeyor only, as the assembly we are producing here is platform agnostic / pure-MSIL) |
Could you shortly explain why this Travis CI build would be useful in addition to the AppVeyor build? The AppVeyor build is already building for net451 and netstandard1.6. |
Hey @felschr! Usually repos have both AppVeyor and TravisCI configured, to keep ensuring the xplat-ness and step aside related issue before they emerge in public landscape. For instance, unless we re-read the documentation of .NET BCL APIs that we have been using for ages, we never know which API will throw In README, I read:
I am planning to consume this package for the app running on Unix, knowing Azure has released the DocDB package supporting .NET Core. So I cloned your repo and found that you already have the support in master branch. |
I see. So we should try to find a way to run the tests on Travis CI. Or rather find a way to run the tests on a Linux machine. Am I right? |
@felschr, I agree that we must be able to run tests. Unfortunately, DocDB emulator is only available on Windows; native Unix support is on their long-term roadmap https://docs.microsoft.com/en-us/azure/documentdb/documentdb-nosql-local-emulator (see comments). We can use xunit traits to disable the affected tests for non-Windows for now, but there are only few such tests. |
Sounds good. |
Uses dotnet-cli `v1.0.0-rc4-004771` without `mono` to specifically build `netstandard1.6` TFM.
@felschr, done. Can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git tag creation and GitHub release could probably be removed.
Otherwise, it looks good. I'll check the Git/Github behavior later.
Ok, everything looks quite ok.
The 2nd Travis CI build is successful because it skips the git tag creation because the commit was now tagged by AppVeyor. The question is now: |
Perhaps it was the first time on the master branch and some Travis<->GitHub syncing failed? Might be the intermittent error? On a slightly related note, the TravisCI badge in the README has link to netcore branch. Perhaps we can apply the following patch: - [![Travis CI build status](https://travis-ci.org/FelschR/aspnetcore-identity-documentdb.svg?branch=netcore)](https://travis-ci.org/FelschR/aspnetcore-identity-documentdb?branch=netcore)
+ [![Travis CI build status](https://travis-ci.org/FelschR/aspnetcore-identity-documentdb.svg?branch=netcore)](https://travis-ci.org/FelschR/AspNetCore.Identity.DocumentDB) Also, I was thinking to add macOS and Mono (requires separate SLN with old-CSPROJ facade) to the matrix by extracting out the script to a separate .sh file, like what we did here: https://github.com/maxmind/MaxMind-DB-Reader-dotnet/blob/9d247d7/.travis.yml. :) |
Just did a build and noticed the same thing again: first build failed with Github error, 2nd went through. |
Uses dotnet-cli
v1.0.0-rc4-004771
withoutmono
to specificallybuild
netstandard1.6
TFM.Progress towards #14.