update geometry.ex to force recompilation on upgrade

[aeruder]

This will fix the upgrade weirdness when switching between branches on 3.4.3 and 3.4.4. Right now since all we did was add the optional dependency, it apparently isn't enough to encourage Elixir 1.15 to recompile this module -- however, if we actually make a (very minor) change on the upgrade, it will recompile every time.

[aeruder]

This was mentioned in #164 but I apparently missed these emails for the last 4 days. 😞

[aeruder]

Unfortunately too late for 3.4.4 but perhaps worth cutting a 3.4.5 to avoid the weirdness around changing branches?

[s3cur3]

Oh! Interesting... yeah, the fix makes sense to me, and in my testing, it works reliably when going forward (that is, from 3.4.3 to the PR branch), but I still get an unknown type Geo.PostGIS.Geometry error going back from the PR branch to v3.4.3.

In any case, it seems like it helps with the migration path, so I'm gonna cut a release. 👍

[adamu]

Isn't this an issue with how Postgrex works?

Postgrex.Types.define/3 must be called on its own file, outside of any module and function, as it only needs to be defined once during compilation.

Because of this, every time a dependency used when calling define/3 is updated, if there are no changes to the upstream definition in application code, the necessary changes won't be pulled in, at least for incremental builds.