Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Update UnitConverter.jsx #266

Merged
merged 1 commit into from Dec 9, 2021
Merged

Update UnitConverter.jsx #266

merged 1 commit into from Dec 9, 2021

Conversation

Aniket-508
Copy link
Contributor

@Aniket-508 Aniket-508 commented Dec 8, 2021

Closes Issue

#251

Changes Made

Converted all the style for classes and id to styled divs and also changed all the pixel values to rem.

@Aniket-508 Aniket-508 requested a review from a team as a code owner December 8, 2021 18:59
@Aniket-508
Copy link
Contributor Author

@sahil-shubham Please have a look at this!

@sahil-shubham sahil-shubham linked an issue Dec 9, 2021 that may be closed by this pull request
2 tasks
Copy link
Contributor

@sahil-shubham sahil-shubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks so much better now, thanks for putting in the time and effort @Aniket-508

Merging this now.

@sahil-shubham sahil-shubham merged commit 2aae76c into felvin-search:master Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve unit convertor's code
2 participants