Export / Split: fix panics when the target file is read only

fengalin · Apr 3, 2019 · 9cd3b5d · 9cd3b5d
1 parent 00da795
commit 9cd3b5d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/media/splitter_pipeline.rs b/src/media/splitter_pipeline.rs
@@ -116,7 +116,7 @@ impl SplitterPipeline {
         this.pipeline
             .set_state(gst::State::Paused)
             .map(|_| this)
-            .map_err(|_| gettext("Could not set media in Paused mode"))
+            .map_err(|_| gettext("do you have permission to write the file?"))
     }
 
     pub fn get_position(&self) -> Option<u64> {
@@ -335,11 +335,9 @@ impl SplitterPipeline {
                     return glib::Continue(false);
                 }
                 gst::MessageView::Error(err) => {
-                    sender
-                        .send(MediaEvent::FailedToExport(
-                            err.get_error().description().to_owned(),
-                        ))
-                        .unwrap();
+                    let _ = sender.send(MediaEvent::FailedToExport(
+                        err.get_error().description().to_owned(),
+                    ));
                     return glib::Continue(false);
                 }
                 gst::MessageView::AsyncDone(_) => {

diff --git a/src/media/toc_setter_pipeline.rs b/src/media/toc_setter_pipeline.rs
@@ -63,7 +63,7 @@ impl TocSetterPipeline {
         this.pipeline
             .set_state(gst::State::Paused)
             .map(|_| this)
-            .map_err(|_| gettext("Could not set media in Paused mode"))
+            .map_err(|_| gettext("do you have permission to write the file?"))
     }
 
     pub fn get_muxer(&self) -> Option<&gst::Element> {
@@ -190,11 +190,9 @@ impl TocSetterPipeline {
                     return glib::Continue(false);
                 }
                 gst::MessageView::Error(err) => {
-                    sender
-                        .send(MediaEvent::FailedToExport(
-                            err.get_error().description().to_owned(),
-                        ))
-                        .unwrap();
+                    let _ = sender.send(MediaEvent::FailedToExport(
+                        err.get_error().description().to_owned(),
+                    ));
                     return glib::Continue(false);
                 }
                 gst::MessageView::AsyncDone(_) => {