Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CLI parameter to deactivate gtkglsink on linux #121

Closed
fengalin opened this issue May 17, 2018 · 0 comments
Closed

Add a CLI parameter to deactivate gtkglsink on linux #121

fengalin opened this issue May 17, 2018 · 0 comments
Assignees
@fengalin
Labels
enhancement

Comments

@fengalin
Copy link
Owner

gtkglsink on linux is broken with some drivers, which is the case for my setups so I discarded it. It would be valuable for other systems, so a CLI parameter could allow deactivating it when it raises issues. When I implement preferences, this could be a persistent application parameter.

On macOS, it seems to be working, so gtkglsink could be activated all the time.
@fengalin fengalin self-assigned this May 17, 2018
@fengalin fengalin changed the title Add a CLI parameter to activate gtkglsink on linux Add a CLI parameter to deactivate gtkglsink on linux May 18, 2018
fengalin added a commit that referenced this issue May 18, 2018
@fengalin
Add a CLI parameter to deactivate gtkglsink (#121)
6b7e817 
Still need to check this on a system for which `gtkglsink` is operational.

`PlaybackContext` should handle the failure when the `video_sink` fails to
synchronize with its parent. This may occur on system where `gtkglsink` is
not operational and `gst-plugins-bad` is not installed. An error message
should be presented in such a case with an instruction to either install
`gst-plugins-bad` or to run the application with `--disable-gl`.
fengalin added a commit that referenced this issue May 18, 2018
@fengalin
PlaybackContext: detect and report gl issues (#121)
7799f05 
This still needs to be verified on a system with proper gl handling.
fengalin added a commit that referenced this issue May 18, 2018
@fengalin
Update fr translation (#121)
13c8958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengalin fengalin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fengalin