Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance waveform rendering #15

Closed
fengalin opened this issue Aug 14, 2017 · 1 comment
Closed

Enhance waveform rendering #15

fengalin opened this issue Aug 14, 2017 · 1 comment
Assignees

Comments

@fengalin
Copy link
Owner

Displaying the waveforms on a single graph results in a clumsy representation. The first channels rendered are hidden by the last ones if they have larger amplitude.

I don't feel that the channel information is pertinent to the definition of a chapter start or end position. Drawing a mono waveform would reduce the sample buffer, which in turn would reduce the computation needed to draw the waveform and the time spent draining the buffer.

For aesthetic reasons, we could keep the information of which channel has the highest amplitude before mixing down, and draw the sample using a colour matching this channel. It might also be too clumsy though as that could result in a sort of colour patchwork.

@fengalin fengalin self-assigned this Aug 14, 2017
@fengalin fengalin changed the title Mixdown audio to one channel Enhance waveform rendering Aug 14, 2017
@fengalin
Copy link
Owner Author

Yes indeed, it doesn't look good with multiple colours. Let's keep it simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant