Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split mode: remove upstream TOC #88

Closed
fengalin opened this issue Dec 16, 2017 · 4 comments
Closed

Split mode: remove upstream TOC #88

fengalin opened this issue Dec 16, 2017 · 4 comments
Assignees
@fengalin
Labels
bug

Comments

@fengalin
Copy link
Owner

In split mode, the original media TOC is included in each output file. It shouldn't.
@fengalin fengalin self-assigned this Dec 16, 2017
@fengalin fengalin added the bug label Dec 16, 2017
@fengalin
Copy link
Owner Author

The problem is due to the implementation in wavenc (which is the same in flacenc): these elements use a dedicated toc field instead of relying on the gst_toc_[gs]etter mechanisms. That's the reason why toc_setter.reset() has no effect from an application.

The same is true for tags.

@fengalin
Copy link
Owner Author

See this discussion.

fengalin added a commit that referenced this issue Dec 21, 2017
@fengalin
Splitter: workaround to remove upstream TOC (#88)
9496c37
fengalin added a commit that referenced this issue Dec 21, 2017
@fengalin
Minor cleanups (#88)
a93bd09
fengalin added a commit that referenced this issue Dec 21, 2017
@fengalin
TocSetterContext: drop Upstream TOC(s) (#88)
7d35f87
@fengalin
Copy link
Owner Author

See also this enhancement proposal.

@fengalin
Copy link
Owner Author

Closing this as I have a solution for media-toc, whatever the final decision on my proposal for GstTocSetter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengalin fengalin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fengalin