Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adpButtonBarPositiveButtonStyle with Holo theme #45

Closed
vyndor opened this issue Apr 3, 2015 · 5 comments
Closed

adpButtonBarPositiveButtonStyle with Holo theme #45

vyndor opened this issue Apr 3, 2015 · 5 comments

Comments

@vyndor
Copy link

vyndor commented Apr 3, 2015

Hi,
I'm trying to change text color for positive button. It works well with Material theme but doesn't affect Holo theme.
My styles.xml:


    <!-- Application theme. -->
    <style name="AppTheme" parent="AppBaseTheme">
        ...
        <item name="alertDialogProTheme">@style/CustomAlertDialog</item>
    </style>

    <style name="CustomAlertDialog" parent="Theme.AlertDialogPro.Material.Light">
        <item name="adpButtonBarPositiveButtonStyle">@style/CustomDialogPositiveButton</item>
    </style>

    <style name="CustomDialogPositiveButton" parent="Widget.AlertDialogPro.Material.Light.Button">
        <item name="android:textColor">@color/bittersweet</item>
    </style>
@fengdai
Copy link
Owner

fengdai commented Apr 4, 2015

Sorry, I didn't understand your point. Did you mean your styles didn't work on pre-lollipop device?

@vyndor
Copy link
Author

vyndor commented Apr 4, 2015

No, I would like to customize exactly Holo theme. But style I pass to adpButtonBarPositiveButtonStyle doesn't change anything. Maybe adpButtonBarPositiveButtonStyle is not supported for Holo?

@fengdai fengdai closed this as completed in 8d9b9e7 Apr 4, 2015
@fengdai
Copy link
Owner

fengdai commented Apr 4, 2015

I have found the reason. I didn't use adpButtonBarPositiveButtonStyle in the Holo layout.

@vyndor
Copy link
Author

vyndor commented Apr 4, 2015

Thank you!
I'm new to gradle build system, can you please tell me how can I get your latest changes?

@fengdai
Copy link
Owner

fengdai commented Apr 5, 2015

You can use 'com.github.fengdai:alertdialogpro-theme-holo:0.2.2'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants