Skip to content

Commit

Permalink
Remove Keystone from existing tests (trailofbits#1684)
Browse files Browse the repository at this point in the history
* Cache generated ASM

* Never install Keystone on the CI

* Fix dict retreival one-liner

arguments aren't lazily evaluted, so ks_assemble always got called

* Apply suggestions from code review

Docstrings and type hints

Co-authored-by: Brad Larsen <brad.larsen@trailofbits.com>

* Update tests/native/test_armv7cpu.py

Missed one

Co-authored-by: Brad Larsen <brad.larsen@trailofbits.com>

Co-authored-by: Brad Larsen <brad.larsen@trailofbits.com>
  • Loading branch information
Eric Hennenfent and Brad Larsen committed May 11, 2020
1 parent 90b4d45 commit b1d93d2
Show file tree
Hide file tree
Showing 5 changed files with 2,213 additions and 24 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,7 @@ jobs:
# Install solc unconditionally because it only takes a second or two
sudo wget -O /usr/bin/solc https://github.com/ethereum/solidity/releases/download/v0.4.24/solc-static-linux
sudo chmod +x /usr/bin/solc
EXTRAS="dev-noks"
if [[ "$TEST_TYPE" == "native" ]]; then
EXTRAS="dev"
fi
pip install -e .[$EXTRAS]
pip install -e ".[dev-noks]"
- name: Run Tests
env:
TEST_TYPE: ${{ matrix.type }}
Expand Down
Loading

0 comments on commit b1d93d2

Please sign in to comment.