Improve issue #34

fengyuanchen · Jul 8, 2014 · 351a916 · 351a916
1 parent f7005da
commit 351a916
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 14 deletions.
diff --git a/dist/cropper.css b/dist/cropper.css
@@ -1,5 +1,5 @@
 /*!
- * Cropper v0.3.6
+ * Cropper v0.3.7
  * https://github.com/fengyuanchen/cropper
  *
  * Copyright 2014 Fengyuan Chen

diff --git a/dist/cropper.js b/dist/cropper.js
@@ -1,5 +1,5 @@
 /*!
- * Cropper v0.3.6
+ * Cropper v0.3.7
  * https://github.com/fengyuanchen/cropper
  *
  * Copyright 2014 Fengyuan Chen
@@ -202,11 +202,13 @@
                 cropper.left = (container.width - cropper.width) / 2;
             }
 
-            cropper = Cropper.fn.floor(cropper);
+            // Calculate the ratio value first before use the "Math.floor"
+            // https://github.com/fengyuanchen/cropper/issues/34
+            image.ratio = cropper.width / image.naturalWidth;
 
+            cropper = Cropper.fn.floor(cropper);
             image.height = cropper.height;
             image.width = cropper.width;
-            image.ratio = image.width / image.naturalWidth;
 
             Cropper.fn.position($container);
             this.$cropper.css({
@@ -786,8 +788,7 @@
                 data = $this.data("cropper");
 
             if (!data) {
-                data = new Cropper(this, options);
-                $this.data("cropper", data);
+                $this.data("cropper", (data = new Cropper(this, options)));
             }
 
             if (typeof options === "string" && $.isFunction(data[options])) {

diff --git a/dist/cropper.min.css b/dist/cropper.min.css
diff --git a/dist/cropper.min.js b/dist/cropper.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "cropper",
     "description": "A simple jQuery image cropping plugin.",
-    "version": "0.3.6",
+    "version": "0.3.7",
     "keywords": [
         "image",
         "cropping",

diff --git a/src/cropper.js b/src/cropper.js
@@ -194,11 +194,13 @@
                 cropper.left = (container.width - cropper.width) / 2;
             }
 
-            cropper = Cropper.fn.floor(cropper);
+            // Calculate the ratio value first before use the "Math.floor"
+            // https://github.com/fengyuanchen/cropper/issues/34
+            image.ratio = cropper.width / image.naturalWidth;
 
+            cropper = Cropper.fn.floor(cropper);
             image.height = cropper.height;
             image.width = cropper.width;
-            image.ratio = image.width / image.naturalWidth;
 
             Cropper.fn.position($container);
             this.$cropper.css({
@@ -778,8 +780,7 @@
                 data = $this.data("cropper");
 
             if (!data) {
-                data = new Cropper(this, options);
-                $this.data("cropper", data);
+                $this.data("cropper", (data = new Cropper(this, options)));
             }
 
             if (typeof options === "string" && $.isFunction(data[options])) {