Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 97 bubble sort #120

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

resilient-maximus
Copy link

No description provided.

@fengyuanyang
Copy link
Owner

Hi @irohitsatya
It seems this pr doesn't pass coverage check.

Rule violated for class com.ordestiny.tdd.algorithms.SortingAlgorithms: lines covered ratio is 0.90, but expected minimum is 0.95

Could you fix it

@resilient-maximus
Copy link
Author

resilient-maximus commented Oct 27, 2020 via email

@fengyuanyang
Copy link
Owner

Hi, I am not sure how to fix this issue. Could you guide me with this please? Regards, Rohit Satya

On Tue, 27 Oct, 2020, 6:41 pm Owen Yang, @.***> wrote: Hi @irohitsatya https://github.com/irohitsatya It seems this pr doesn't pass coverage check. Rule violated for class com.ordestiny.tdd.algorithms.SortingAlgorithms: lines covered ratio is 0.90, but expected minimum is 0.95 Could you fix it — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#120 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRZCKXPF436LX2IYL4NVWLSM3BI5ANCNFSM4TAREYSQ .

You can execute gradle tasks below by orders

  1. test
  2. jacocoTestReport

and check index.html under customJacocoReportDir
to see which line is not coverd.

@fengyuanyang
Copy link
Owner

Hi @irohitsatya
Have you given it a try ?

@resilient-maximus
Copy link
Author

resilient-maximus commented Oct 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants