Merge pull request #250 from fenos/develop

v4.0.2
fenos · Jan 13, 2017 · 0bba585 · 0bba585
2 parents 89345fb + 2a9474a
commit 0bba585
Show file tree

Hide file tree

Showing 27 changed files with 19 additions and 18 deletions.
diff --git a/.coveralls.yml b/.coveralls.yml
@@ -1,3 +1,3 @@
 coverage_clover: build/logs/clover.xml
 json_path: build/logs/coveralls-upload.json
-service_name: travis-ci
+service_name: travis-ci
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,3 @@
 /vendor
 composer.lock
-/build
+/build
diff --git a/.scrutinizer.yml b/.scrutinizer.yml
@@ -6,4 +6,7 @@ filter:
     - tests/*
 build:
   environment:
-    php: 7.0.6
+    php: 7.0.6
+  dependencies:
+    after:
+      - composer dump-autoload -o
diff --git a/.travis.yml b/.travis.yml
@@ -57,4 +57,4 @@ after_script:
 
 ## Send Build Notifications to Slack
 notifications:
-  slack: notifynder:CnF7P2xaZuJTJ4VzNOy6ksDH
+  slack: notifynder:CnF7P2xaZuJTJ4VzNOy6ksDH
diff --git a/CoverageChecker.php b/CoverageChecker.php
@@ -4,13 +4,11 @@
 $percentage = min(100, max(0, (int) $argv[2]));
 
 if (! file_exists($inputFile)) {
-    echo $inputFile." isn't present.";
-    exit(0);
+    throw new RuntimeException($inputFile." isn't present.");
 }
 
 if (! $percentage) {
-    echo $percentage." isn't percentage.";
-    exit(0);
+    throw new RuntimeException($percentage." isn't a percentage value.");
 }
 
 $xml = new SimpleXMLElement(file_get_contents($inputFile));
@@ -26,8 +24,7 @@
 $coverage = ($checkedElements / $totalElements) * 100;
 
 if ($coverage < $percentage) {
-    echo 'Code coverage is '.$coverage.'%, which is below the accepted '.$percentage.'%'.PHP_EOL;
-    exit(1);
+    throw new RuntimeException('Code coverage is '.$coverage.'%, which is below the accepted '.$percentage.'%');
 }
 
 echo 'Code coverage is '.$coverage.'% - OK!'.PHP_EOL;
diff --git a/README.md b/README.md
@@ -4,6 +4,8 @@
 [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg?style=flat-square)](https://raw.githubusercontent.com/fenos/Notifynder/master/LICENSE)
 [![GitHub issues](https://img.shields.io/github/issues/fenos/Notifynder.svg?style=flat-square)](https://github.com/fenos/Notifynder/issues)
 [![Total Downloads](https://img.shields.io/packagist/dt/fenos/notifynder.svg?style=flat-square)](https://packagist.org/packages/fenos/notifynder)
+[![VersionEye](https://www.versioneye.com/user/projects/5878c014a21fa90051522611/badge.svg?style=flat-square)](https://www.versioneye.com/user/projects/5878c014a21fa90051522611)
+[![SensioLabs Insight](https://img.shields.io/sensiolabs/i/ef2a6768-337d-4a88-ae0b-8a0eb9621bf5.svg?style=flat-square&label=SensioLabs)](https://insight.sensiolabs.com/projects/ef2a6768-337d-4a88-ae0b-8a0eb9621bf5)
 
 [![Travis branch](https://img.shields.io/travis/fenos/Notifynder/master.svg?style=flat-square&label=TravisCI)](https://travis-ci.org/fenos/Notifynder/branches)
 [![StyleCI](https://styleci.io/repos/18425539/shield)](https://styleci.io/repos/18425539)

diff --git a/composer.json b/composer.json
@@ -22,11 +22,9 @@
   },
   "require-dev": {
     "laravel/framework": "~5.0",
-    "phpunit/phpunit": "~4.0",
-    "phpspec/phpspec": "~2.1",
+    "phpunit/phpunit": "~4.0|~5.0",
     "laracasts/testdummy": "~2.0",
     "orchestra/testbench": "~3.0",
-    "doctrine/dbal": "^2.5",
     "codeclimate/php-test-reporter": "^0.3.2",
     "satooshi/php-coveralls": "^1.0"
   },

diff --git a/phpspec.yml b/phpspec.yml
diff --git a/phpunit.xml b/phpunit.xml
diff --git a/src/Notifynder/Builder/Builder.php b/src/Notifynder/Builder/Builder.php
diff --git a/src/Notifynder/Contracts/NotifynderManagerContract.php b/src/Notifynder/Contracts/NotifynderManagerContract.php
diff --git a/src/Notifynder/Managers/NotifynderManager.php b/src/Notifynder/Managers/NotifynderManager.php
diff --git a/src/Notifynder/Models/Notification.php b/src/Notifynder/Models/Notification.php
diff --git a/src/Notifynder/Models/NotificationCategory.php b/src/Notifynder/Models/NotificationCategory.php
diff --git a/src/Notifynder/NotifynderServiceProvider.php b/src/Notifynder/NotifynderServiceProvider.php
diff --git a/src/Notifynder/Senders/SingleSender.php b/src/Notifynder/Senders/SingleSender.php
@@ -2,7 +2,6 @@
 
 namespace Fenos\Notifynder\Senders;
 
-use Fenos\Notifynder\Models\Notification;
 use Fenos\Notifynder\Contracts\SenderContract;
 use Fenos\Notifynder\Contracts\SenderManagerContract;
 

diff --git a/src/Notifynder/Traits/Notifable.php b/src/Notifynder/Traits/Notifable.php
diff --git a/src/Notifynder/Traits/NotifableBasic.php b/src/Notifynder/Traits/NotifableBasic.php
diff --git a/src/Notifynder/Traits/NotifableLaravel53.php b/src/Notifynder/Traits/NotifableLaravel53.php
diff --git a/src/config/notifynder.php b/src/config/notifynder.php
diff --git a/src/migrations/2014_02_10_145728_notification_categories.php b/src/migrations/2014_02_10_145728_notification_categories.php
diff --git a/src/migrations/2014_08_01_210813_create_notification_groups_table.php b/src/migrations/2014_08_01_210813_create_notification_groups_table.php
diff --git a/src/migrations/2014_08_01_211045_create_notification_category_notification_group_table.php b/src/migrations/2014_08_01_211045_create_notification_category_notification_group_table.php
diff --git a/src/migrations/2015_05_05_212549_create_notifications_table.php b/src/migrations/2015_05_05_212549_create_notifications_table.php
diff --git a/src/migrations/2015_06_06_211555_add_expire_time_column_to_notification_table.php b/src/migrations/2015_06_06_211555_add_expire_time_column_to_notification_table.php
@@ -1,5 +1,6 @@
 <?php
 
+use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Database\Migrations\Migration;
 
 class AddExpireTimeColumnToNotificationTable extends Migration
@@ -11,7 +12,7 @@ class AddExpireTimeColumnToNotificationTable extends Migration
      */
     public function up()
     {
-        Schema::table('notifications', function ($table) {
+        Schema::table('notifications', function (Blueprint $table) {
             $table->timestamp('expire_time')->nullable();
         });
     }
@@ -23,7 +24,7 @@ public function up()
      */
     public function down()
     {
-        Schema::table('notifications', function ($table) {
+        Schema::table('notifications', function (Blueprint $table) {
             $table->dropColumn('expire_time');
         });
     }

diff --git a/src/migrations/2015_06_06_211555_change_type_to_extra_in_notifications_table.php b/src/migrations/2015_06_06_211555_change_type_to_extra_in_notifications_table.php
diff --git a/src/migrations/2015_06_07_211555_alter_category_name_to_unique.php b/src/migrations/2015_06_07_211555_alter_category_name_to_unique.php
@@ -1,5 +1,6 @@
 <?php
 
+use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Database\Migrations\Migration;
 
 class AlterCategoryNameToUnique extends Migration
@@ -11,7 +12,7 @@ class AlterCategoryNameToUnique extends Migration
      */
     public function up()
     {
-        Schema::table('notification_categories', function ($table) {
+        Schema::table('notification_categories', function (Blueprint $table) {
             $table->unique('name');
         });
     }
@@ -23,7 +24,7 @@ public function up()
      */
     public function down()
     {
-        Schema::table('notification_categories', function ($table) {
+        Schema::table('notification_categories', function (Blueprint $table) {
             $table->dropUnique('notification_categories_name_unique');
         });
     }