Removed unused $categoryId parameter from the NotificationParser pars…

…e function
fenos · Jun 27, 2017 · 349ed53 · 349ed53
1 parent c517aff
commit 349ed53
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/src/Notifynder/Builder/Notification.php b/src/Notifynder/Builder/Notification.php
@@ -165,7 +165,7 @@ public function getText()
             $notification = new ModelNotification($this);
             $notifynderParse = new NotificationParser();
 
-            return $notifynderParse->parse($notification, $this->category_id);
+            return $notifynderParse->parse($notification);
         }
     }
 

diff --git a/src/Notifynder/Models/Notification.php b/src/Notifynder/Models/Notification.php
@@ -132,7 +132,7 @@ public function getTextAttribute()
     {
         if (! array_key_exists('text', $this->attributes)) {
             $notifynderParse = new NotificationParser();
-            $this->attributes['text'] = $notifynderParse->parse($this, $this->category_id);
+            $this->attributes['text'] = $notifynderParse->parse($this);
         }
 
         return $this->attributes['text'];

diff --git a/src/Notifynder/Parsers/NotificationParser.php b/src/Notifynder/Parsers/NotificationParser.php
@@ -21,11 +21,10 @@ class NotificationParser
      * Parse a notification and return the body text.
      *
      * @param ModelNotification $notification
-     * @param int $categoryId
      * @return string
      * @throws ExtraParamsException
      */
-    public function parse($notification, $categoryId)
+    public function parse($notification)
     {
         $category = $notification->category;
         if (is_null($category)) {

diff --git a/tests/integration/Parsers/NotificationParserTest.php b/tests/integration/Parsers/NotificationParserTest.php
@@ -6,9 +6,8 @@
 
 class NotificationParserTest extends NotifynderTestCase
 {
-    public function testThrowsModelNotFoundExceptionIfCategoryIsNull()
+    public function testParseThrowsModelNotFoundExceptionIfCategoryIsNull()
     {
-        $category = $this->createCategory();
         $from = $this->createUser();
         $to = $this->createUser();
         $notification = new Notification();
@@ -18,6 +17,6 @@ public function testThrowsModelNotFoundExceptionIfCategoryIsNull()
 
         $this->expectException(ModelNotFoundException::class);
         $parser = new NotificationParser();
-        $parser->parse($notification, $category->id);
+        $parser->parse($notification);
     }
 }