configure.ac: added pthread macro #90
Conversation
Fixes: fenrus75#84 Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| AC_PREREQ([2.69]) | |||
| AC_INIT([powertop], [2.14], [powertop@lists.01.org], [], [https://01.org/powertop]) | |||
| AC_CANONICAL_TARGET | |||
There was a problem hiding this comment.
This is almost never what you want to use. See https://flameeyes.blog/2008/10/12/you-dont-want-to-canonicalise-that-and-im-not-referring-to-ubuntu/
There was a problem hiding this comment.
I suspect you added this because AX_PTHREAD appeared to need it. This was a bug and was fixed in autoconf-archive/autoconf-archive#233. See the discussion in autoconf-archive/autoconf-archive@2567e0c
Unfortunately, while the revert landed in master months ago the autoconf-archive maintainer has not made another release, despite multiple pings, thereby confirming our worries that this was going to trigger problems downstream.
There was a problem hiding this comment.
Yep, thanks for info.
| @@ -42,6 +43,7 @@ AM_PROG_CC_C_O | |||
| AX_ADD_FORTIFY_SOURCE | |||
| AX_CXX_COMPILE_STDCXX([11], [noext], [mandatory]) | |||
| PKG_PROG_PKG_CONFIG | |||
| AX_PTHREAD | |||
There was a problem hiding this comment.
This macro is used immediately below already, so if there's something to fix it's probably in the existing usage.
|
The current git head builds OK without the patch, so sorry for noise. |
Fixes: #84
Signed-off-by: Jaroslav Škarvada jskarvad@redhat.com