fix(rss): Fix parsing RDF feeds

closes #22
fent · Feb 22, 2018 · 66da5eb · 66da5eb
1 parent 15d56a2
commit 66da5eb
Show file tree

Hide file tree

Showing 3 changed files with 1,098 additions and 7 deletions.
diff --git a/lib/xmlfeedparser.js b/lib/xmlfeedparser.js
@@ -1,3 +1,5 @@
+'use strict';
+
 const sax = require('sax');
 
 
@@ -85,10 +87,9 @@ module.exports = (buffer) => {
 
   // First start listening for the root tag.
   var openf1 = function(node) {
-    var type;
     if (node.name === 'channel' || node.name === 'feed') {
       if (node.name === 'feed') {
-        type = 'atom';
+        let type = 'atom';
         obj.type = type;
         this.emit('type', type);
       }
@@ -98,8 +99,8 @@ module.exports = (buffer) => {
       parser.on('opentag', onopentag);
       parser.on('closetag', onclosetag);
 
-    } else if (node.name === 'rss') {
-      type = 'rss ' + node.attributes.version;
+    } else if (node.name === 'rss' || node.name === 'rdf:rdf') {
+      let type = 'rss ' + (node.attributes.version || '1.0');
       obj.type = type;
       this.emit('type', type);
     } else {
@@ -150,9 +151,13 @@ module.exports = (buffer) => {
       obj[key] = cleanObj(obj[key]);
 
     if (!stack.length) {
-      key = key === 'entry' || key === 'items' ? 'item' : key;
-      parser.emit(key, data);
-      if (!buffer) { delete obj[key]; }
+      var skey = key === 'entry' || key === 'items' ? 'item' : key;
+      // Some feeds will contain a summary of items at the top.
+      // Ignore this.
+      if (key !== 'items' || Array.isArray(data)) {
+        parser.emit(skey, data);
+        if (!buffer) { delete obj[key]; }
+      }
     }
   }