Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node prefix #44

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Node prefix #44

wants to merge 13 commits into from

Conversation

demosjarco
Copy link

Node as of v14.13.1 has added support for node: prefixes to denote every core library. Going forward, new libraries created will only be available via the prefix (for example see node:test).

Some platforms such as Cloudflare Workers support these apis at runtime only, but due to how they use node to dynamically inject their apis, they require the node: prefix as well.

demosjarco and others added 13 commits May 22, 2023 22:42
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1.0.3 to 3.1.4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.0.3...v3.1.4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v1...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 1 to 3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v1...v3)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
since we're updating TS and node types
@demosjarco
Copy link
Author

If you want to stay on the same major version, @types/node does work on 14.14.10 but there's no need to stay on such an old version.

  • @types/node - 16.18.32
  • @types/node - 18.16.14
  • @types/node - 20.2.3

all work even with as far back as Node v14.21.3

Copy link
Owner

@fent fent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! this PR still contains changes that you've added in the other two PRs, i'm guessing you meant to not include them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants