made a library more customisable for defining a key form which to take a unique value #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
fent
requested changes
Mar 13, 2023
| @@ -110,3 +116,36 @@ Tests are written with [mocha](https://mochajs.org) | |||
| ```bash | |||
| npm test | |||
| ``` | |||
|
|
|||
| #Example of usage | |||
There was a problem hiding this comment.
there's already an example at the top of the readme
| }); | ||
| reader.read(); | ||
|
|
||
| setInterval(() => { |
There was a problem hiding this comment.
no need for this with the interval option
| @@ -8,7 +8,7 @@ | |||
| "json", | |||
| "subscribe" | |||
| ], | |||
| "version": "0.7.6", | |||
| "version": "0.7.9", | |||
There was a problem hiding this comment.
the package auto updates the version once a PR is merged
| requestOpts: {}, | ||
|
|
||
| // keys to get a unique value from items, first not null will be used | ||
| uniqueKeyNames: ['guid'], |
There was a problem hiding this comment.
Use the default values, ['pubdate', 'lastbuilddate', 'updated']
| @@ -64,8 +70,15 @@ export default class FeedSub extends TypedEmitter<FeedSubEvents> { | |||
| skipDays : false, | |||
| daysToSkip : null, | |||
| requestOpts : {}, | |||
| uniqueKeyNames : ['pubdate', 'lastbuilddate', 'updated'], | |||
| getUniqueValueFromItem: false | |||
There was a problem hiding this comment.
what do you think of removing this field and always using uniqueKeyNames?
| @@ -56,6 +61,7 @@ export default class FeedSub extends TypedEmitter<FeedSubEvents> { | |||
| forceInterval : false, | |||
| autoStart : false, | |||
| emitOnStart : false, | |||
| lastUniqueIdentifierValue : null, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.