Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add an extra check in getAuthor from utils, so that error isn't… #340

Closed
wants to merge 1 commit into from

Conversation

lokiiarora
Copy link

… stagnant and we can check for it when using the library

… stagnant and we can check for it when using the library
@codecov
Copy link

codecov bot commented Jul 22, 2018

Codecov Report

Merging #340 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #340   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         579    594   +15     
  Branches      144    154   +10     
=====================================
+ Hits          579    594   +15
Impacted Files Coverage Δ
lib/util.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a4b36...4a6add3. Read the comment docs.

@fent
Copy link
Owner

fent commented Jul 22, 2018

You seem to be running a formatter that changed the style of all library files. Do you mind undoing the formatting and committing only the changes to getAuthor?

@kelyvin
Copy link
Contributor

kelyvin commented Aug 2, 2018

+1

This pull request addresses the issue I'm encountering, which I have documented here: #349.

However, given that it's almost two weeks old with no updates, I have submitted my own update here: #350. Thanks!

@fent fent closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants