Fixed related videos returning empty array

[ashikmeerankutty]

Fixes #479
Before

After

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #479: related_videos is always empty

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[NightScript370]

Can you include a link to the author as well? It'd be really useful

[ashikmeerankutty]

Can you include a link to the author as well? It'd be really useful

ucid contains the youtube channel id. using the id you can create the channel URL.

[fent]

Hey, thank you for taking the time to make the PR. I added some comments to the changes.

one thing I noticed is the formatting of the code added. I try to keep the formatting for all files using the same style. in this case, a space after a comma, and using camelCase for variables. linting should probably be added to the build process so it warns about these things, but I can do that later

[fent]

also, add semicolons wherever missing

[cloudrac3r]

Seems like YouTube's changed something yet again. You should check again that this works.

[fent]

Seems like YouTube's changed something yet again. You should check again that this works.

I just checked with a few videos, seems to work

[fent]

just noticed a few issues

• view_count contains commas, that can easily be fixed with a .replace().
• length_seconds should be in seconds, not in time format. you can parse this with the humanStr() function from the m3u8stream module. it's used here:

  node-ytdl-core/lib/index.js

  Line 96 in 9aa2f4b

  format.url += '&begin=' + parseTime.humanStr(options.begin);

  , it returns milliseconds btw
• short_view_count_text can be parsed too with parseTime.durationStr(), should add another property to the object and call it short_view_count

[ashikmeerankutty]

• short_view_count_text can be parsed too with parseTime.durationStr(), should add another property to the object and call it short_view_count

when I tried parseTime.durationStr() on short_view_count_text i'm getting these results

[fent]

when I tried parseTime.durationStr() on short_view_count_text i'm getting these results

ah, sorry, my mistake. durationStr() is for parsing time strings. I'm ok with keeping it this way, since it was previously in this format anyway.

[fent]

thank you! and thank you for the patience with my comments

[ashikmeerankutty]

:

thank you! and thank you for the patience with my comments

Thank you for your comments, that helped me a lot 👍