fix escaped backslashes towards end of string & add test #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fent
reviewed
Jan 20, 2021
Co-authored-by: fent <fentbox@gmail.com>
all fine |
|
🎉 This PR is included in version 4.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TimeForANinja
added a commit
to TimeForANinja/node-ytsr
that referenced
this pull request
Jan 20, 2021
* copy the changes provided in fent/node-ytdl-core#862 to ytsr * this also closes #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of nested loops or some lookback regex i decided on adding a simple boolean to track if the current character is escaped by a previous backslash or not
also added a test case to check for this in the future
closes #861