Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hints in RandomMotion #1104

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

blakedewey
Copy link
Contributor

Description

Fix type hints in the RandomMotion __init__ method, which should allow for tuples of floats in degrees and translation. This type hint now matches the docstring.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed

Fix type hints in the `RandomMotion` `__init__` method, which should allow for tuples of floats in `degrees` and `translation`
Copy link
Owner

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @blakedewey. I've suggested some changes.

@fepegar fepegar merged commit 84560fe into fepegar:main Sep 19, 2023
12 of 13 checks passed
@fepegar
Copy link
Owner

fepegar commented Sep 19, 2023

@all-contributors please add @blakedewey for doc

@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @blakedewey! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants