Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4D I/O incompatibility with ITK #286

Merged
merged 6 commits into from Aug 19, 2020
Merged

Fix 4D I/O incompatibility with ITK #286

merged 6 commits into from Aug 19, 2020

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented Aug 19, 2020

Fixes #285.

@fepegar fepegar changed the title Add I/O test for 4D images Fix 4D I/O incompatibility with ITK Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #286 into master will decrease coverage by 0.17%.
The diff coverage is 86.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   92.98%   92.81%   -0.18%     
==========================================
  Files         108      108              
  Lines        5063     5035      -28     
==========================================
- Hits         4708     4673      -35     
- Misses        355      362       +7     
Impacted Files Coverage Δ
...ms/preprocessing/test_histogram_standardization.py 100.00% <ø> (ø)
tests/utils.py 94.87% <66.66%> (-2.50%) ⬇️
torchio/utils.py 83.24% <75.00%> (-5.76%) ⬇️
torchio/data/image.py 90.16% <85.71%> (+<0.01%) ⬆️
torchio/data/io.py 96.24% <89.47%> (+2.25%) ⬆️
tests/data/test_image.py 100.00% <100.00%> (ø)
tests/data/test_io.py 100.00% <100.00%> (+1.02%) ⬆️
...eprocessing/intensity/histogram_standardization.py 94.26% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bce83...2cd6d36. Read the comment docs.

@fepegar fepegar merged commit 47d3da6 into master Aug 19, 2020
@fepegar fepegar deleted the 285-4d-itk branch August 19, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4D I/O is incompatible with ITK
1 participant