Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to modify interpolation when inverting #418

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented Jan 14, 2021

Resolves #410.

Description
See #410.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #418 (6827698) into master (e83024c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   92.35%   92.41%   +0.05%     
==========================================
  Files         126      128       +2     
  Lines        6230     6496     +266     
==========================================
+ Hits         5754     6003     +249     
- Misses        476      493      +17     
Impacted Files Coverage Δ
tests/transforms/test_invertibility.py 100.00% <100.00%> (ø)
torchio/data/subject.py 96.57% <100.00%> (+0.09%) ⬆️
...preprocessing/intensity/normalization_transform.py 91.30% <0.00%> (-2.45%) ⬇️
torchio/transforms/__init__.py 100.00% <0.00%> (ø)
torchio/transforms/preprocessing/__init__.py 100.00% <0.00%> (ø)
...hio/transforms/preprocessing/label/remap_labels.py 100.00% <0.00%> (ø)
...ransforms/preprocessing/label/sequential_labels.py 100.00% <0.00%> (ø)
torchio/transforms/preprocessing/label/one_hot.py 33.33% <0.00%> (ø)
.../transforms/preprocessing/label/label_transform.py 100.00% <0.00%> (ø)
...s/augmentation/intensity/random_labels_to_image.py 96.00% <0.00%> (+0.29%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83024c...6827698. Read the comment docs.

@fepegar fepegar marked this pull request as ready for review January 19, 2021 16:16
@fepegar fepegar merged commit 1c90543 into master Jan 19, 2021
@fepegar fepegar deleted the 410-inverse-interpolation branch January 19, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use different interpolation for inverted random resampling transforms
1 participant