Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Indirect notifications showing as direct notification in taskbark #816

Closed
1 task done
FeikoJoosten opened this issue Dec 1, 2022 · 1 comment · Fixed by #1495
Closed
1 task done

Bug: Indirect notifications showing as direct notification in taskbark #816

FeikoJoosten opened this issue Dec 1, 2022 · 1 comment · Fixed by #1495
Labels
bug 🪲 Something isn't working

Comments

@FeikoJoosten
Copy link
Contributor

Avoid duplicates

  • I have searched the issues tracker for a bug report similar to mine, in vain

Ferdium Version

6.2.1

What Operating System are you using?

Windows

Operating System Version

Windows 10 Pro 19044.2251

What arch are you using?

x64

Last Known Working Ferdium version

No response

Expected Behavior

The indicator on the ferdium icon located on the taskbar should be a blue dot when you only have indirect notifications available and a red dot when you have a direct notification available.

Actual Behavior

No matter the notification types available, only a red dot is being shown

Steps to reproduce

  1. Receive an indirect notification
  2. Notice the red dot on the ferdium taskbark icon

Debug link

https://debug.ferdium.org/e6ac9f39-8855-4484-85a5-c86e230cfb80

Screenshots

image
(I have no other notifications at this point in time)

Additional information

No response

@FeikoJoosten FeikoJoosten added the bug 🪲 Something isn't working label Dec 1, 2022
@FeikoJoosten
Copy link
Contributor Author

Pretty sure this can be solved by taking over the logic from

} else if (typeof args.indicator === 'string') {
for defining if the direct or indirect app icon should be shown as the taskbar icon is being rendered properly. This should be be placed in
if (indicator === '•') {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant