Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 'electron-builder' to '24.4.0' #1166

Merged
merged 1 commit into from May 14, 2023

Conversation

Alphrag
Copy link
Member

@Alphrag Alphrag commented May 13, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade to the latest version of electron-builder.

Motivation and Context

We have tried to use version 24 of electron-builder before, but had to revert it in e6c60b6 as the rebuild of sqlite3 on the CI for Mac arm machines was not working and the app couldn't launch on such computers.
Since then electron/rebuild has been patched (cf electron/rebuild#1078) and the associated version has been included in electron-builder 24.3.0.

Screenshots

Capture d’écran 2023-05-13 à 20 31 13

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam
Copy link
Contributor

I have confirmed that I am able to build from this PR branch on a mac m1 and am able to open and use that version of Ferdium sucessfully. I think this PR is ready for review and merge.

@Alphrag
Copy link
Member Author

Alphrag commented May 14, 2023

Thanks for checking. I left it as draft initially only to wait for nightly.5 to get triggered without including this PR to see if something goes wrong what was the culprit.

@Alphrag Alphrag marked this pull request as ready for review May 14, 2023 08:29
@Alphrag Alphrag requested a review from a team as a code owner May 14, 2023 08:29
@vraravam vraravam merged commit 7450875 into ferdium:develop May 14, 2023
4 checks passed
@Alphrag Alphrag deleted the electron-builder-24.4.0 branch May 14, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants