Allow user to choose install location on windows #1204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Allow Windows users to choose whether to install globally on the machine or to keep it on a user level. Solves #1172 but revert #1198 in the process.
Motivation and Context
Some users want to install Ferdium globally on the machine instead of installing only for the current user. PR #1198 changed the default behaviour and made all install per machine when it was per user previously. This PR gives the possibility to choose the location of the installation by exposing the assisted installer instead of making the installation silent. As a consequence, updating is no longer fully automatic and requires the user to validate its choice.
Possible future improvement: create/modify the nsis script to only ask for the install location on first installation, and then make the update silent by using the current installation location.
Screenshots
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes