Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to choose install location on windows #1204

Merged
merged 2 commits into from
May 29, 2023

Conversation

Alphrag
Copy link
Member

@Alphrag Alphrag commented May 29, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Allow Windows users to choose whether to install globally on the machine or to keep it on a user level. Solves #1172 but revert #1198 in the process.

Motivation and Context

Some users want to install Ferdium globally on the machine instead of installing only for the current user. PR #1198 changed the default behaviour and made all install per machine when it was per user previously. This PR gives the possibility to choose the location of the installation by exposing the assisted installer instead of making the installation silent. As a consequence, updating is no longer fully automatic and requires the user to validate its choice.

Possible future improvement: create/modify the nsis script to only ask for the install location on first installation, and then make the update silent by using the current installation location.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes

Release Notes

@Alphrag Alphrag requested a review from a team as a code owner May 29, 2023 12:00
@vraravam vraravam merged commit 22f9237 into ferdium:develop May 29, 2023
4 checks passed
@Alphrag Alphrag deleted the Fix-windows-installer branch May 29, 2023 12:34
Alphrag added a commit to Alphrag/ferdium-app that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants