Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder: Use core22 as snap base #1457

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Nov 26, 2023

By default electron-builder uses core18 as base, this is quite old at this point while core22 is the latest stable version and safer to use.

So use it as ferdium base.

It's also the same version where ferdium is built in CI.

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Motivation and Context

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

By default electron-builder uses core18 as base, this is quite old at
this point while core22 is the latest stable version and safer to use.

So use it as ferdium base.
@3v1n0 3v1n0 requested a review from a team as a code owner November 26, 2023 22:51
@mcmxcdev mcmxcdev merged commit 851c0d7 into ferdium:develop Nov 27, 2023
4 checks passed
@mcmxcdev
Copy link
Contributor

Nice one! Strange that electron-builder is using old core18 by default still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants