Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade electron to v28.1.3 #1517

Merged
merged 1 commit into from Jan 12, 2024
Merged

chore: upgrade electron to v28.1.3 #1517

merged 1 commit into from Jan 12, 2024

Conversation

xduugu
Copy link
Contributor

@xduugu xduugu commented Jan 12, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

  • upgraded electron to v28.1.3

Motivation and Context

Several fixes for security issues and updated chromium.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

chore: upgrade electron to v28.1.3

@xduugu xduugu requested a review from a team as a code owner January 12, 2024 00:12
Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine! Thank you!

@mcmxcdev
Copy link
Contributor

Everything looks fine! Thank you!

Does zoom in and out still work?

@SpecialAro
Copy link
Member

Everything looks fine! Thank you!

Does zoom in and out still work?

Yes, but still doesn't persist when changing webviews. For that we will need to wait for 29.

@mcmxcdev
Copy link
Contributor

Everything looks fine! Thank you!

Does zoom in and out still work?

Yes, but still doesn't persist when changing webviews. For that we will need to wait for 29.

SGTM, lets get it merged!

@SpecialAro SpecialAro merged commit 1b1529b into ferdium:develop Jan 12, 2024
4 checks passed
@SpecialAro
Copy link
Member

@all-contributors please add @xduugu for infra

Copy link
Contributor

@SpecialAro

I've put up a pull request to add @xduugu! 🎉

vraravam added a commit to vraravam/ferdium-app that referenced this pull request Jan 13, 2024
vraravam added a commit that referenced this pull request Jan 13, 2024
* Revert "chore: upgrade electron to v28.1.3 (#1517)"

This reverts commit 1b1529b.

* Upgrade electron to '27.2.2' from '27.1.3'
@mcmxcdev mcmxcdev mentioned this pull request Jan 13, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants