New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade electron to v28.1.3 #1517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine! Thank you!
Does zoom in and out still work? |
Yes, but still doesn't persist when changing webviews. For that we will need to wait for 29. |
SGTM, lets get it merged! |
@all-contributors please add @xduugu for infra |
I've put up a pull request to add @xduugu! 🎉 |
This reverts commit 1b1529b.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Motivation and Context
Several fixes for security issues and updated chromium.
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes
chore: upgrade electron to v28.1.3