Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removable-media snap interface #227

Merged

Conversation

NathanaelGandhi
Copy link
Contributor

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Add the removable-media snap interface. Gives snap users the option to manually connect the interface, allowing read/write access to mounted removable storage in /media, /run/media and /mnt. Interface is connected using snap connect ferdium:removable-media

Motivation and Context

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (electron-builder formatting)
  • I previewed my changes locally (formatting similar to existing)

Release Notes

Add removable-media snap interface

@NathanaelGandhi
Copy link
Contributor Author

@vraravam This is a similar PR to #215. Interface added in the same format as existing. Ready for review & merge.

Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vraravam vraravam merged commit cf18289 into ferdium:develop Jun 11, 2022
@vraravam
Copy link
Contributor

@all-contributors please add @NathanaelGandhi for code

@allcontributors
Copy link
Contributor

@vraravam

I've put up a pull request to add @NathanaelGandhi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants