Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring the draggable area back on MacOS #372

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

cino
Copy link
Contributor

@cino cino commented Jun 26, 2022

Description of Change

This change brings the "invisible" draggable area back on macOS, the reason this was removed was that the elements behind it weren't clickable anymore. However, the reason this was happening wasn't actually because of the draggable area but because of the feature that enables the window to be maximized by double-clicking that area (hence the capturing of click events).

My proposed solution is to bring the draggable area back and reduce the double-click area to 10px which increases the area where you can click and expect the normal behaviour.

Motivation and Context

  • To improve UX and allow the window to be dragged while on macOS without visible draggable area

This should fix:

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

@kris7t kris7t requested a review from a team June 26, 2022 17:08
@vraravam vraravam merged commit 5336850 into ferdium:develop Jun 26, 2022
@cino cino mentioned this pull request Jun 27, 2022
1 task
@cino cino deleted the macos-draggable-window branch June 28, 2022 08:34
@cino cino mentioned this pull request Jun 28, 2022
1 task
@j7e
Copy link

j7e commented Nov 23, 2022

Per the reply to #793 - #793 (comment) - after exploring further, the Settings screen referred to in the reply is not directly accessible from the splash screen menu bar but only available once the user is past the splash screen, either by logging in or using without an account. The fix is not obvious to a new user; because Ferdium didn't behave in a standard way, my initial impression was that it was broken. At this point, a new user might reasonably conclude the same and abandon it, which does not seem desirable.

Could I suggest i) something on the splash screen to draw attention to troubleshooting issues (or this issue in particular) and ii) making the Settings screen available from the splash screen menu bar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants