Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change notarization runner #381

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

Alphrag
Copy link
Member

@Alphrag Alphrag commented Jun 27, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Use the notarytool instead of the legacy version in electron-notarize.

Motivation and Context

A build failed to notarize, which could be due to the use of the legacy version of the notarization runner. This legacy version uses xcrun altool --notarize-app ... instead of using the newer xcode development tools that use xcrun notarytool ... that are called by the notarytool version of electron-notarize.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • I tested/previewed my changes on my personal fork

Use the `notarytool` instead of the `legacy` version in `electron-notarize`
Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vraravam vraravam merged commit 1edf3b4 into ferdium:develop Jun 27, 2022
@Alphrag Alphrag deleted the fix-notarization branch June 27, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants