Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable API Server recipes updates #382

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

SpecialAro
Copy link
Member

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

  • Ferdium App won't install API Server recipes updates

Motivation and Context

As discussed in #314 and #224, and also in discord with @vraravam, this PR disables COMPLETELY the in-app recipes updates from the server.

I think this is the way to go to have a fully functional release soon, by making the app totally independent of the recipes on the server.

Ergo, for the user to get recipes updates, it needs to download a new Ferdium version, which will - after the first run of the new updated version - pop up the Reload Services message to update recipes to the newest version (bundled with the App).

DISCLAIMER: This can possible (not tested but most surely will) break the future of supporting custom recipes updates through a custom server - if users are using them to manage multiple account sync of custom recipes.

Screenshots

Please, look at the console:

Before
image
After
image

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Disable API Server recipes updates

@SpecialAro SpecialAro self-assigned this Jun 27, 2022
@SpecialAro SpecialAro requested review from vraravam and a team June 27, 2022 13:51
src/stores/RecipesStore.ts Outdated Show resolved Hide resolved
@vraravam vraravam force-pushed the disable-external-recipes-updates branch 2 times, most recently from c2b166f to 56c6355 Compare June 27, 2022 15:40
@SpecialAro SpecialAro force-pushed the disable-external-recipes-updates branch from 56c6355 to 0796f08 Compare June 27, 2022 16:05
@SpecialAro SpecialAro requested review from vraravam and a team June 27, 2022 16:07
@vraravam vraravam merged commit 1deb48c into ferdium:develop Jun 27, 2022
@SpecialAro SpecialAro deleted the disable-external-recipes-updates branch June 28, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants