Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: turn last setting view into typescript #386

Merged
merged 1 commit into from
Jun 27, 2022
Merged

chore: turn last setting view into typescript #386

merged 1 commit into from
Jun 27, 2022

Conversation

cino
Copy link
Contributor

@cino cino commented Jun 27, 2022

Description of Change

  • Last of the settings views into typescript, wasn't sure if it was being used before but it is.

Motivation and Context

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

SpecialAro
SpecialAro approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vraravam
vraravam approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested locally

@vraravam vraravam merged commit 81fc26b into ferdium:develop Jun 27, 2022
@cino cino deleted the support-screen-typescript branch June 28, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vraravam vraravam vraravam approved these changes

@SpecialAro SpecialAro SpecialAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cino @vraravam @SpecialAro