Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default accent color if the user removes value from textbox (fixes #368) #450

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jul 9, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Use the default accent color if the user deletes the value from the text box in the preferences screen.

Motivation and Context

Fixes #368

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team July 9, 2022 02:46
@vraravam vraravam self-assigned this Jul 9, 2022
@vraravam vraravam merged commit 71b43ae into ferdium:develop Jul 9, 2022
@vraravam vraravam deleted the fix-368 branch July 9, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Empty value in Accent Color input Crash the App in any reload
1 participant