Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome screen and SetupAssistant changes #472

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

SpecialAro
Copy link
Member

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

  • Convert several files from js to jsx and fix lint
  • Add back buttons on Login, Signup and Select Server pages - removed the previous text.
  • Add ability to skip adding recipes after Signup (in SetupAssistant)
  • Change default to no recipe selected when in SetupAssistant screen

Motivation and Context

There was a need of a cleaner UI with back elements and also a skip button on Setup Assistant screen.

Screenshots

Welcome Screens

Login Signup Change Server
image image image

SetupAssistant Screen

image image

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Welcome screen and SetupAssistant changes

@SpecialAro SpecialAro requested a review from a team July 12, 2022 16:30
@SpecialAro SpecialAro self-assigned this Jul 12, 2022
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!!!

@vraravam vraravam merged commit 6415f27 into ferdium:develop Jul 12, 2022
@SpecialAro SpecialAro deleted the Auth-screen-change branch July 13, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants