fix: desktopCapturer in electron 17+ (fixes #59) #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Description of Change
This patch adds a new IPC message from the service renderer to the main process so it can still invoke
desktopCapturer.getSources
as per https://www.electronjs.org/docs/latest/breaking-changes#removed-desktopcapturergetsources-in-the-rendererMotivation and Context
Since electron 17,
desktopCapturer
is only available in the main process: https://www.electronjs.org/blog/electron-17-0#desktopcapturergetsources-in-the-rendererThis should fix #59 and maybe also #32.
Checklist
npm run prepare-code
)npm test
passesRelease Notes
Fixed screen sharing in services