Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement widevine cdm #720

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: implement widevine cdm #720

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
088070a
feat: implement widevine cdm
bchen290 Oct 30, 2022
dd92205
fix: async await components.whenReady()
bchen290 Oct 30, 2022
afd1288
revert: undo changes to Windows build script
bchen290 Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 6 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
"concurrently": "7.4.0",
"cross-env": "7.0.3",
"dotenv": "16.0.3",
"electron": "21.2.0",
"electron": "github:castlabs/electron-releases#v21.2.0+wvcus",
"electron-builder": "23.6.0",
"eslint": "8.25.0",
"eslint-config-airbnb": "19.0.4",
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ else
Write-Host "*************** Building recipes ***************"
# Note: 'recipes' is already using only pnpm - can switch to $BASE_CMD AFTER both repos are using pnpm
Push-Location recipes
pnpm i && pnpm lint && pnpm reformat-files && pnpm package
pnpm i; pnpm lint; pnpm reformat-files; pnpm package
bchen290 marked this conversation as resolved.
Show resolved Hide resolved
Pop-Location

# -----------------------------------------------------------------------------
Expand Down
6 changes: 6 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import {
app,
BrowserWindow,
components,
globalShortcut,
ipcMain,
session,
Expand Down Expand Up @@ -417,6 +418,11 @@ const createWindow = () => {
trayIcon._toggleWindow();
});
}

while (!components.whenReady()) {
kris7t marked this conversation as resolved.
Show resolved Hide resolved
debug('components status:', components.status());
}
debug('components ready:', components.status());
});
};

Expand Down