Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discord badge counts #461

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Fix Discord badge counts #461

merged 5 commits into from
Nov 10, 2023

Conversation

Cknight70
Copy link
Contributor

@Cknight70 Cknight70 commented Nov 6, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Discord numbered unread message badges as well as all new message badge is currently not working. This will fix both of these issues. As discussed here ferdium/ferdium-app#1370

@Cknight70
Copy link
Contributor Author

Hi, I'm not sure why its failing the check, but you can see files changed that I have changed the version number. I've been using ferdium with these changes and it works without issues, thanks.

@mydarkstar mydarkstar self-requested a review November 10, 2023 04:55
@mydarkstar mydarkstar changed the title Fix Discord Notifications Fix Discord badge counts Nov 10, 2023
@mydarkstar mydarkstar merged commit 48ec989 into ferdium:main Nov 10, 2023
1 of 2 checks passed
@mydarkstar
Copy link
Member

@all-contributors please add @Cknight70 for code

Copy link
Contributor

@mydarkstar

I've put up a pull request to add @Cknight70! 🎉

@nerdCopter
Copy link

Thank you you for fixing it!

It would be my preference not to see this blue circle. i do not like it.
image

If it is not part of your PR, then my apologies.

@Cknight70
Copy link
Contributor Author

Cknight70 commented Dec 4, 2023

@nerdCopter that is indicating indirect unread messages, which you can turn off by turning off notifications for all messages in that ferdium instance (right click edit )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants