Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of Tutanota to Tuta Mail #463

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Change name of Tutanota to Tuta Mail #463

merged 3 commits into from
Nov 27, 2023

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Nov 15, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

tuta renamed and changed domain

image

image

@mydarkstar mydarkstar self-requested a review November 17, 2023 03:47
Copy link
Member

@mydarkstar mydarkstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the submission!
However, the id / recipeId has to stay the same, as otherwise this PR would be breaking the recipe already in use in clients.

Please don't rename the directory nor the id value in the package.json.
It may also be desirable to add an alias (aliases) for "Tutanota".

The Twitter / X PR can be used as a reference:
https://github.com/ferdium/ferdium-recipes/pull/423/files

Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on #464 , has the icon changed as well?

@noraj
Copy link
Contributor Author

noraj commented Nov 25, 2023

based on #464 , has the icon changed as well?

yes true, you can merge the duplicate PR with the icon

@mydarkstar
Copy link
Member

based on #464 , has the icon changed as well?

The logo and brand colors of Tuta have not changed, no. They just use the "lazy" method of dark mode and invert the colors.

However, I have noticed upon logging in, that the entire UI of this recipe is now branded "Tuta Mail".
The same goes for the GitHub repository and F-Droid app.

So it seems like that would be the most appropriate name.

Tuta brands their client behind this recipe as "Tuta Mail".
As per my comment in ferdium#463.
@mydarkstar mydarkstar changed the title tuta name change Change name of Tutanota to Tuta Mail Nov 26, 2023
@mydarkstar mydarkstar merged commit ac09880 into ferdium:main Nov 27, 2023
2 checks passed
@noraj noraj deleted the tuta branch November 28, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants