fix badge for Instagram #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this fix! To be able to merge this, please update the version in package.json of the instagram recipe as described in https://github.com/ferdium/ferdium-recipes/blob/main/docs/updating.md#4-updating-the-version-number |
2 tasks
|
Thank you for feedback ! I update version and complet the fix |
vraravam
approved these changes
Nov 25, 2023
If not notification on instagram element html as null, set 0 if not notification
vraravam
requested changes
Nov 25, 2023
|
I running the commande |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
I have fixed the badge of notifications for the Instagram and Instagram-direct-messages applications. The query selector now directly retrieves the value within the that contains the number of notifications.